Add CustomHeaders member to GitPushOptions #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix libgit2#1217 Matches underlying c struct for marshalling
Closed
nulltoken
added a commit
that referenced
this pull request
Nov 12, 2015
Add CustomHeaders member to GitPushOptions
|
Awesome! Many thanks to @golsby and you ✨ |
|
You're welcome! I'm happy to help. Fortunately, I've got @pearswj as a colleague who has much better git-fu than me to do the rebasing and commit squashing to clean up your commit log. |
|
I notice this was added - but I don't see a parallel to CustomHeaders in PushOptions.cs so how does it make it's way to the Proxy? |
|
These custom headers are still not exposed to the end user since they are not included in PushOptions, unless I'm missing a different way to do this? There seems to be an open PR with a fix though: #2011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CustomHeaders member to GitPushOptions to match underlying c struct for marshalling. Fixes #1217 (error when pushing to private repo).
Supersedes #1218 – @golsby asked me to tidy things up and resubmit as per @nulltoken's comments.