Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use git paths, not win32 file paths #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2017

Conversation

ethomson
Copy link
Member

No description provided.

Clement Bellot and others added 4 commits April 27, 2016 14:29
These paths use a slash for separation, and attempts to hide this behind FilePath
end up making it more complex to figure out what we should accept. Move to accept
strings and keep them as such instead of trying to convert them.
We treat a lot of the data as paths which would be available on the host
system, but this doesn't need to be the case. There are paths which the
filesystem or .NET won't accept which work just fine as paths inside
Git.

This also means the return values are also marshalled as strings, since
we can't assume they contain paths which the path marshaller would
like. It also keeps the separator as the slash rather than convert it
into something which seems native, but is different from what we'd
accept.

The paths which we do refer to as paths inside the workdir are still
marhshalled as paths.
@ethomson ethomson merged commit e323be6 into master Jun 25, 2017
@ethomson ethomson deleted the ethomson/git-paths-are-not-file-paths branch February 15, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants