Add SubmoduleCollection.Add #1501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f1bb67 to
9c43f85
Compare
|
I need this functionality too. What needs to be done to get this added? I can probably work on it some if needed. I saw in a past PR a review comment that this code should be in |
JohnathanFL
added a commit
to JohnathanFL/libgit2sharp-submodules
that referenced
this pull request
Mar 12, 2023
Credit to libgit2#1501 / JasonGoemaat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
SubmoduleCollection.Add(url, path, useGitLink).Looking for some input here if this can be done a better way. The docs say call
git_submodule_add_setup(), then clone the repo or whatever, then callgit_submodule_add_finalize()to add the submodule and '.gitmodules' to the index.I wasn't sure how to create a
Submodulewithout a name, or is that just the path? It seems like cloning the repository into the desired directory first and then calling both setup and finalize methods works fine and is how it is actually done when creating a new submodule, isn't it?