Add Stash first implementation #352
Conversation
| namespace LibGit2Sharp.Core | ||
| { | ||
| ///<summary> | ||
| /// the different options to create a new stash |
There was a problem hiding this comment.
How about
/// <summary>
/// Options controlling Stash behavior.
/// </summary>|
Wow... Bringing Stash to LibGit2Sharp? Amazing! 💥 Few more tiny things:
|
|
that's a lot of comments! 😄 |
| Stash stash = repo.Stashes.Add(stasher); | ||
|
|
||
| Assert.NotNull(stash); | ||
| Assert.Equal("stash@{0}", stash.CanonicalName); |
There was a problem hiding this comment.
Could please assert, that the Message from the Tip is not empty nor null?
|
Awesome! I think the main thing I noticed was that message was not exposed on the Also, do you want tests covering other |
@Saaman I concur with @jamill
👍 That makes perfect sense. @Saaman Could you please cover the including of Ignored files as well?
Once again @jamill hit the 🎱 I completely overlooked this. How about a |
|
I will push a new version of the stash, with :
|
|
I just pushed my modifications. It turns out I saw something odd : |
That looks like a bug. However, after having thought a bit about this, I realize I don't really know how git.git does behave regarding the stashing of ignored files. Would this even make sense to remove them from the workdir? I'm going to investigate this and will report about my findings. Merged! 💥 |
I added the management of stashes into LibGit2Sharp.
For now, you can add an list stashes, (with bindings to
git_stash_saveandgit_stash_foreach).I took
Repository.Tagsas an example to manage the stashes collection.I'll push to you the implementation of
Removea little while later.