Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactored Repository.Checkout to use CheckoutOptions #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Defavlt
Copy link

@Defavlt Defavlt commented Nov 7, 2013

No description provided.

@nulltoken
Copy link
Member

Wow! That looks like a very good start ✨

Few mandatory nitpicks:

  • In order to ease the task for the consumers, could you please add a message to the [Obsolete] attributes pointing at the correct overload signatures? You can peek at 0d00a5f for some inspiration 😉
  • Please remove all the code beautification changes. They make the diff quite harder to read.
  • Could you update the code of the deprecated methods so that they redirect to the newly added ones?
  • I may be wrong, but I think you might have forgotten to also consider at least Branch.cs and IRepository.cs (Finding all occurrences of CheckoutModifiers should help you cover all your bases)
  • In order to keep the tests up-to-date, could you please also make sure they all leverage the non deprecated versions of Checkout() methods?

@nulltoken
Copy link
Member

Hey @Defavlt! How are things going?

If there anything we can do to help you with this PR, please let us know.

@nulltoken
Copy link
Member

Closing this due to lack of activity.

@nulltoken nulltoken closed this Mar 14, 2014
@nulltoken nulltoken added this to the UnmergedOrDoNotRequireAFix milestone Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants