Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Nuget improvements #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Nuget improvements #778

wants to merge 11 commits into from

Conversation

MicahZoltu
Copy link
Contributor

  • Adds a new project to the solution for building a native NuGet package.
    • The package ends up in bin\<configuration>.
    • When the package is installed, a build target file is imported into the target project that will cause the binaries to be copied to $(TargetPath) after build (if necessary).
    • Versioned as the last version of the LibGit2 that was pulled into this repository.
    • Do not be fooled, this is not actually a .csproj. In order to get Visual Studio to load it so that it shows up in Solution Explorer you have to tag it as one of a known list of project file types (http://msdn.microsoft.com/en-us/library/vstudio/ms171468(v=vs.110).aspx). If you try to view the properties on it, Visual Studio will add a bunch of stuff to the underlying project file. I don't think anything will break, but if it adds back the imports I believe it will break. Be aware, best to just not open the properties on the project and instead open it in a text editor.
  • Changes NuGet package to be generated on successful build of the class library.
    • The package ends up in bin\<configuration>.
    • Depends on the Native NuGet package (see above).
    • Only installs the one library and the one dependency, nothing fancy.
  • Adds dependency on NuGet for MSBuild.
    • Both projects have a .targets file added to them that utilizes NuGet for MSBuild.
    • Take care in updating NuGet for MSBuild, it will add some post-build tasks to your project when you install/update it. I have removed these but they will come back if you update. They may have undesired side effects.
    • I have committed the dependency to the repo, I would encourage you (project owners) to .gitignore packages/ though since Visual Studio will restore them on first build automatically (since VS2012 Update ? I believe).

@MicahZoltu
Copy link
Contributor Author

Note, this is similar in desired outcome as #772, but I took a different route which is why I didn't build on that.

@MicahZoltu
Copy link
Contributor Author

The Travis CI build failure is due to a bug in xbuild (mono). I have fixed the bug over at the mono project but I don't know when that will be released.

@Therzok
Copy link
Member

Therzok commented Sep 8, 2014

Can we force rebuilding this? That bug should be gone with the new mono version.

@carlosmn
Copy link
Member

carlosmn commented Sep 8, 2014

The merged code which GitHub provides is still against the old version. This PR would need a new push for it to get tested against current vNext.

@nulltoken
Copy link
Member

Note, this is similar in desired outcome as #772, but I took a different route which is why I didn't build on that.

/cc @ethomson

@MicahZoltu
Copy link
Contributor Author

Rebased onto the head of vNext. Unfortunately it appears the MacOS X Travis CI server is still running Mono 3.6, which does not contain the fix. The fix can be found here:
mono/mono@7008bb6
According to the tags, it is first available in mono-3.8.0.

I'm looking into the new failure on the linux build server (which is running 3.8).

@MicahZoltu
Adds NuGet package building to end of build and separates out Native …
70e8b1b 
…NuGet project.

The Native libraries now ship in a separate NuGet package which the managed NuGet package depends on.  All package building is done as part of the build process and managed with MSBuild targets.
@MicahZoltu
Makes Native NuGet package copy the native libraries to $(TargetDir) …
03d96f0 
…on build of the project the package is added to.
@MicahZoltu
Don't re-copy unchanged files (they should basically never change exc…
fe92dfd 
…ept on clean).
@MicahZoltu
Allows Travis CI to build.
d04a05e 
Unfortunately, it doesn't appear that Travis CI doesn't support NuGet package restore (requires NuGet.exe be installed and in the path of the build node).  Un-ignored the packages directory and committed the dependencies into the repo.

Recommendation for maintainers, investigate NuGet package restore in Travis CI.
@MicahZoltu
Changes CreateBuildDirectory to PrepareForBuild.
2699a7d 
xbuild (mono) seems to want a PrepareForBuild target.
@MicahZoltu
Adds message to help troubleshoot Travis CI build failure.
4ab8442
@MicahZoltu
Renames nuspec so NuGet for MSBuild can find it.
825cef5
@MicahZoltu
Gets native nuget package building.
aac796d
@MicahZoltu
Changes NuGet.exe to be executable.
d57dfae 
This is due to a "bug" in mono https://bugzilla.xamarin.com/show_bug.cgi?id=17537.  It is unclear if the bug will ever be fixed since this behavior is undefined in Windows due to a different permission scheme, so how Mono ends up handling it is unknown.
@MicahZoltu
More debugging for build server failures (xbuild).
a64475b
@MicahZoltu
More troubleshooting of xbuild failure.
142ea2e
@MicahZoltu
Copy link
Contributor Author

Another XBuild bug it appears. :/ I filed a bug https://bugzilla.xamarin.com/show_bug.cgi?id=22981 and submitted a pull request mono/mono#1285, I supposed this PR will go back into a waiting state. I have also submitted a bug report to the maintainers of NuGet.for.MSBuild and a recommended fix in case they can get a fix out faster than mono project can:
https://nuget4msbuild.codeplex.com/workitem/9432

@MicahZoltu
Copy link
Contributor Author

Recreated PR off vNext. It was too much trouble to rebase/merge this one, so I just created a new branch. New PR can be found here: #896.

@MicahZoltu MicahZoltu closed this Jan 3, 2015
@MicahZoltu MicahZoltu mentioned this pull request Jan 3, 2015
Closed
@nulltoken nulltoken added this to the UnmergedOrDoNotRequireAFix milestone Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UnmergedOrDoNotRequireAFix
Development

Successfully merging this pull request may close these issues.
4 participants
@MicahZoltu @Therzok @carlosmn @nulltoken