Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#872 Use NuGet package restore to install development dependencies. #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

#872 Use NuGet package restore to install development dependencies. #888

wants to merge 4 commits into from

Conversation

jamiehumphries
Copy link
Contributor

Removes all of Moq and xunit from Lib/, these are now installed by NuGet package restore. Also removes the Lib/NuGet/ in favour of the more conventional `.nuget/' directory.

Package restore is set to happen automatically on build, but this is implemented slightly differently than the approach that @nulltoken suggests on #872. Rather than writing a manual BeforeBuild event it relies on the standard <RestorePackages>true</RestorePackages> tag in the csproj file.

@jamiehumphries
Copy link
Contributor Author

The Travis CI build failure here is at lines 630-631:

WARNING: Error: SendFailure (Error writing headers)
Unable to find version '4.2.1409.1722' of package 'Moq'.

This seems similar to this StackOverflow post: http://stackoverflow.com/questions/25935382/nuget-packages-for-visual-studio-2012-will-not-restore-in-monodevelop-5-0-1

Something is not entirely happy with running NuGet on Mono...

@jamiehumphries
Copy link
Contributor Author

All well now, just some certificate issues with the NuGet restore that were fixed with mozroots --import --sync.

@Therzok
Copy link
Member

Therzok commented Dec 18, 2014

👍

@nulltoken
Copy link
Member

@jamiehumphries 👍 Nice contribution!

However by reading this, it seems that the MSBuild-Integrated Package Restore is no longer the preferred approach ("While this approach is still available, the NuGet team suggests using the Automatic Package Restore and Command-Line Package Restore instead.").

So, would you be so kind as as to drop the .nuget folder, (while keeping the nuget.exe in the Lib) folder and make the build scripts (.cmd|.sh) launch the nuget restore?

See also those Migrating MSBuild-Integrated solutions to use Automatic Package Restore and Migrate away from MSBuild-based NuGet package restore posts for further details.

@nulltoken
Copy link
Member

Superseded by #894.

Cheers!

@nulltoken nulltoken closed this Jan 3, 2015
@nulltoken nulltoken added this to the UnmergedOrDoNotRequireAFix milestone Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants