-
Notifications
You must be signed in to change notification settings - Fork 281
Add stash apply & pop support #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Those build failures look legit. Looks like the PR was written against a different version of libgit2. |
Oh my fault, I failed to build the correct target before pushing, and the stash API now has a "nice" |
Sorry, I totally missed that this was ready for re-review. It looks good to me. 👍 Just wanna confirm that this is done from your point of view too. |
My only grudge against it is that it's untested (like, I didn't actually use it, just wrote the wrappers). I might add test cases soon-ish, but if you want to merge, please do. |
Oh lol I totally didn't notice that. Tests would be good 👍 |
Here are some tests. I also made a little tweak to the signatures because I noticed those pesky error pointers weren't at the "right" place... Note that this is not designed to handle conflicts at the moment, since
😟 |
Ugh yeah, I think that PR is our best way forward on that front. This looks good 🤘 |
Sorry, there's no test in there because I wasn't running the greatest and latest Xcode when I wrote that, and time is pretty scarce yadda yadda.