Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ZipArchive 1.1 #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 27, 2016
Merged

ZipArchive 1.1 #557

merged 6 commits into from
Feb 27, 2016

Conversation

phatblat
Copy link
Member

Now consuming the framework instead of source in iOS and Mac test targets

@phatblat
Update ZipArchive to 1.1
1051e87
@phatblat
Consume ZipArchive framework instead of sources
baa9dd2
@phatblat
Remove unused frameworks folder path
6cab7e2 
Gets rid of warning: Directory not found for option '-F/Applications/Xcode7.2.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/Developer/Library/Frameworks'
@phatblat
Add ZipArchive project reference
9d483d8 
This causes Xcode to build the framework as needed so it doesn't need to be prebuilt using carthage
@pietbrauer
Copy link
Member

Build failed because of the warnings in the project.

@phatblat
Copy link
Member Author

Yeah, I saw that earlier with the 1.1 update while the iOS Test target was directly compiling the ZipArchive source.

/Users/travis/build/libgit2/objective-git/Carthage/Checkouts/ZipArchive/SSZipArchive/minizip/zip.c:950:6: error: expression result unused [-Werror,-Wunused-value]
    (crcForCrypting);
     ^~~~~~~~~~~~~~
1 error generated.

Strange that I don't get this error when building the ZipArchive-iOS framework target locally or when building the iOS Tests 😩

@phatblat
Copy link
Member Author

Ah, the Mac Tests are failing because they are still compiling the ZipArchive source directly.

@pietbrauer
Copy link
Member

This would've been spotted by #554 😉

@pietbrauer
Copy link
Member

So much better now. Thanks!

pietbrauer added a commit that referenced this pull request Feb 27, 2016
@pietbrauer
Merge pull request #557 from libgit2/ben/ziparchive1.1
41d4e28 
ZipArchive 1.1
@pietbrauer pietbrauer merged commit 41d4e28 into master Feb 27, 2016
@pietbrauer pietbrauer deleted the ben/ziparchive1.1 branch February 27, 2016 04:42
@pietbrauer pietbrauer mentioned this pull request Mar 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phatblat @pietbrauer