👷🏻♀️🛠 Xcode 9.3 #651
Merged
👷🏻♀️🛠 Xcode 9.3 #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test dependencies are included/build through derived data, so only need to be downloaded with Carthage.
tiennou
approved these changes
Apr 9, 2018
| #import "QuickSpec+GTFixtures.h" | ||
| #import <objc/runtime.h> | ||
| #import <ZipArchive/ZipArchive.h> | ||
| //#import <objc/runtime.h> |
There was a problem hiding this comment.
Yeah, I’ll clean that up
|
Thanks for the nullable cleanup, @tiennou! I'll see if I can finish it off. |
|
Travis now has |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Travis to build with
xcode9.3.Also updated test dependencies and project settings.
Lots of nullability warnings were breaking the build so I relaxed xcconfig's "treat warnings as errors".
I'd like to circle back and clean these up.@tiennou and I cleaned up the nullability warnings. Note that these warnings were disabled in the test targets to keep the test code more lean.