Fix bug in isValidRemoteName #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiennou
requested changes
Sep 10, 2018
ObjectiveGit/GTRemote.m
Outdated
| @@ -104,7 +104,7 @@ - (NSString *)description { | |||
| + (BOOL)isValidRemoteName:(NSString *)name { | |||
| NSParameterAssert(name != nil); | |||
|
|
|||
| return git_remote_is_valid_name(name.UTF8String) == GIT_OK; | |||
| return git_remote_is_valid_name(name.UTF8String); | |||
There was a problem hiding this comment.
I'd prefer return (git_remote_is_valid_name(name.UTF8String) == 1 ? YES : NO); so there's no chance of a -1 error being reported as "true", and we force-map to "BOOL"-compatible values.
According to the docs git_remote_is_valid_name returns either 1 (success) or 0.
17acb08 to
6374f3b
Compare
|
Rebased and pushed |
|
Perfect, thanks ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs git_remote_is_valid_name returns either 1 (success) or 0.