Check for strings before attempting to xfree them #991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rugged_rb_ary_to_strarray
function usesxmalloc
to allocate memory forstr_array->strings
, but there are several cases where this memory might not be allocated:If
rb_array
isNIL_P
, the function returns early withstrings = NULL
. If there's an empty array, the count would be 0. However, in the cleanup sections, the code unconditionally callsxfree(custom_headers.strings)
without checking if it's NULL. This can cause "munmap_chunk(): invalid pointer" errors.Should fix #859