New API: Replace btrfs-fsck with btrfs-scrub-full #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old btrfs-fsck API used "btrfs check" which appears to be broken or deprecated. The real tool you should use is "btrfs scrub". We have already implemented that API, but it is very awkward to use from libguestfs. In particular there's no existing way to run the scrub and wait for it to finish. Fix this by deprecating btrfs-fsck. Implement a new API btrfs-scrub-full which runs btrfs scrub in the foreground, waits for it to finish, and handles errors. It's much more like fsck tools in other filesystems. Thanks: Eric Sandeen Fixes: https://issues.redhat.com/browse/RHEL-91936
1b34755 to
8631389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
btrfs-fsckAPI usedbtrfs checkwhich appears to be broken or deprecated. The real tool you should use isbtrfs scrub. We have already implemented that API, but it is very awkward to use from libguestfs. In particular there's no existing way to run the scrub and wait for it to finish.Fix this by deprecating
btrfs-fsck. Implement a new APIbtrfs-scrub-fullwhich runsbtrfs scrubin the foreground, waits for it to finish, and handles errors. It's much more like fsck tools in other filesystems.Thanks: Eric Sandeen
Fixes: https://issues.redhat.com/browse/RHEL-91936
@crobinso @sandeen