PWX-26915-pt1: Auto-TLS support #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change to "full" service names when using Kuberenetes DNS for discovery * adding Kuberenetes CA for gRPC dial-opts when SSL enabled Signed-off-by: Zoran Rajic <[email protected]>
jrivera-px
reviewed
Dec 2, 2022
| } | ||
| } | ||
|
|
||
| tlsDialOptions, err := grpcserver.GetTlsDialOptions(rootCA) |
Contributor
There was a problem hiding this comment.
If the above condition fails... is there a logging message we want to add?
jrivera-px
approved these changes
Dec 2, 2022
Contributor
jrivera-px
left a comment
There was a problem hiding this comment.
LGTM .. I was thinking that if the CA is required at this point for k8s do we want to log something if its not avail?
Contributor
Author
I think we should be OK "as is" --
|
Signed-off-by: Zoran Rajic <[email protected]>
7e28305 to
6a479ac
Compare
Contributor
Author
|
note.. re-pushed |
Signed-off-by: Zoran Rajic <[email protected]>
Contributor
Author
|
Thanks for the review Jose -- merging the PR |
zoxpx
added a commit
that referenced
this pull request
Dec 8, 2022
* moved K8s CA addition into `appendK8sCaCertBytes()` * calling it from both `BuildTlsConfig()` and `BuildDialOps()`
zoxpx
added a commit
that referenced
this pull request
Dec 8, 2022
* moved K8s CA addition into `appendK8sCaCertBytes()` * calling it from both `BuildTlsConfig()` and `BuildDialOps()` Signed-off-by: Zoran Rajic <[email protected]>
zoxpx
added a commit
that referenced
this pull request
Dec 10, 2022
* moved K8s CA addition into `appendK8sCaCertBytes()` * calling it from both `BuildTlsConfig()` and `BuildDialOps()` Signed-off-by: Zoran Rajic <[email protected]>
zoxpx
added a commit
that referenced
this pull request
Dec 10, 2022
* moved K8s CA addition into `appendK8sCaCertBytes()` * calling it from both `BuildTlsConfig()` and `BuildDialOps()` Signed-off-by: Zoran Rajic <[email protected]>
zoxpx
added a commit
that referenced
this pull request
Dec 13, 2022
* moved K8s CA addition into `appendK8sCaCertBytes()` * calling it from both `BuildTlsConfig()` and `BuildDialOps()` Signed-off-by: Zoran Rajic <[email protected]>
zoxpx
added a commit
that referenced
this pull request
Dec 16, 2022
* moved K8s CA addition into `appendK8sCaCertBytes()` * calling it from both `BuildTlsConfig()` and `BuildDialOps()` Signed-off-by: Zoran Rajic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zoran Rajic [email protected]
What this PR does / why we need it:
These changes are a part of the "auromatic SSL/TLS setup" effort
portworx-service.kube-system.svc.cluster.localportworx-service.kube-systemdns-alias will result in SSL-validation errorsWhich issue(s) this PR fixes (optional)
Closes # PWX-26915 (part 1)
Special notes for your reviewer: