Revert "darwin: speed up uv_set_process_title()" #2405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Aug 3, 2019
cjihrig
approved these changes
Aug 3, 2019
|
@bnoordhuis FWIW, moving the |
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
This reverts commit 00c6b16. It's been reported (and I can confirm) that this change breaks `process.title = 'foo'` in Node.js. Since libuv just calls out to Core Services and Application Services, and since those frameworks are really just black boxes that you can't look inside, it's impossible to debug what exactly goes wrong. Revert it is then. Fixes: nodejs/node#28945 PR-URL: libuv/libuv#2405 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 00c6b16.
It's been reported (and I can confirm) that this change breaks
process.title = 'foo'in Node.js.Since libuv just calls out to Core Services and Application Services,
and since those frameworks are really just black boxes that you can't
look inside, it's impossible to debug what exactly goes wrong. Revert
it is then.
Fixes: nodejs/node#28945
CI: https://ci.nodejs.org/job/libuv-test-commit/1483/