About the inability to clear meta information of png format pictures #4224
Replies: 3 comments 17 replies
-
|
Hello @Williamsu1116, It should work. I see: There's no extra metadata. |
Beta Was this translation helpful? Give feedback.
-
|
Linux environment for docker containers |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@jcupitt It seems the --- a/libvips/foreign/foreign.c
+++ b/libvips/foreign/foreign.c
@@ -1722,8 +1722,8 @@ vips_foreign_save_remove_metadata(VipsImage *image,
VipsForeignKeep keep = *((VipsForeignKeep *) user_data);
// we are only interested in metadata
- if (!vips_isprefix(field, "png-comment-") &&
- !vips_isprefix(field, "magickprofile-") &&
+ if (!vips_isprefix("png-comment-", field) &&
+ !vips_isprefix("magickprofile-", field) &&
strcmp(field, VIPS_META_IMAGEDESCRIPTION) != 0 &&
!g_str_has_suffix(field, "-data"))
return NULL;(I can also submit a PR targeting the |
Beta Was this translation helpful? Give feedback.
-
|
Oh heh that's bad. Sure, please make a PR on 8.16. |
Beta Was this translation helpful? Give feedback.
-
|
I just submitted PR #4225 for this. |
Beta Was this translation helpful? Give feedback.
-
|
... though I don't think that affects this case, it works fine for me: Perhaps you have some error in your filenames @Williamsu1116 ? |
Beta Was this translation helpful? Give feedback.
-
|
Try saving to |
Beta Was this translation helpful? Give feedback.
-
|
Ooops, I tried that, then checked the header of the wrong file. You're right, this needs a PR. |
Beta Was this translation helpful? Give feedback.
-
|
OK, fixed with #4225, this will be in 8.16, due in a few days. Thanks for the report, @Williamsu1116. |
Beta Was this translation helpful? Give feedback.
-
|
I am referring to the bug of clearing the meta information error of png format pictures. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, 8.16.0 has this fix. |
Beta Was this translation helpful? Give feedback.
-
|
But still cannot delete the creator field information in the image's meta information |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
Are you sure you tested this with libvips 8.16? I can't reproduce this: Details$ vipsheader -a exiftool_adobe_after_effects.png
exiftool_adobe_after_effects.png: 316x50 uchar, 4 bands, srgb, pngload
width: 316
height: 50
bands: 4
format: uchar
coding: none
interpretation: srgb
xoffset: 0
yoffset: 0
xres: 1
yres: 1
filename: exiftool_adobe_after_effects.png
vips-loader: pngload
png-comment-0-Creator: Adobe After Effects
xmp-data: 416 bytes of binary data
bits-per-sample: 8
$ vips copy exiftool_adobe_after_effects.png 1105.png[strip]
$ vipsheader -a 1105.png
1105.png: 316x50 uchar, 4 bands, srgb, pngload
width: 316
height: 50
bands: 4
format: uchar
coding: none
interpretation: srgb
xoffset: 0
yoffset: 0
xres: 1
yres: 1
filename: 1105.png
vips-loader: pngload
bits-per-sample: 8 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
vips version is vips-8.15.2，I use the following command, vips resize /pdd/tmp/exiftool_adobe_after_effects.png out-1.jpeg[strip] 1.0
However, the creator field in the meta information still exists in the new image generated.
Beta Was this translation helpful? Give feedback.
All reactions