Fallback to standard temp file if O_TMPFILE fails #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job! Oh dear, you're right, it wasn't being set on Windows, copy-paste error I guess. |
|
This feels like a fix that should go into 8.7.1, what do you think? |
|
Thanks John, yes please to a patch release for this if possible. |
jcupitt
added a commit
that referenced
this pull request
Nov 5, 2018
was not auto-deleteing on windows, needs a fallback on linux see #1155
|
OK, 8.7 HEAD patched too, I'll make an 8.7.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1151, makes the Windows
_O_TEMPORARYbit work again and simplifies the logic so the default and fallback behaviour are both the same statement.This doesn't deal with updating
image->filenameto use theO_TMPFILEfilename. This means that further errors involving the file, if any, will still include/tmp/vips-xxx.vrather than the actual/tmp/random-os-assigned-filename.