spngsave: ensure ICC profiles have a name #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PNG spec requires that the iCCP chunk has a profile name with a minumum length of 1 (we use the same "icc" name as pngsave).
3 tasks
|
Huh what a strange spec. Good fix! |
|
... I'll merge to master as well. Should we make 8.13.2? It's picked up quite a few useful fixes now. |
|
Thanks, and yes please to 8.13.2 when you're ready. |
|
OK, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PNG spec requires that the iCCP chunk has a profile name with a minumum length of 1 (we use the same "icc" name as pngsave).
http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.iCCP
libvips/libvips/foreign/vipspng.c
Lines 1113 to 1115 in 4176ab2
Targets the 8.13 branch as this is a bug fix.
Originally reported at lovell/sharp#3390