Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pdfiumload: add support for forms #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2023
Merged

pdfiumload: add support for forms #3456

merged 2 commits into from
Apr 22, 2023

Conversation

kleisauke
Copy link
Member

Resolves: #3455.

Used https://pdfium.googlesource.com/pdfium/+/main/samples/simple_no_v8.c as reference, without implementing the additional-action calls:

FORM_OnAfterLoadPage
FORM_DoPageAAction
FORM_OnBeforeClosePage
FORM_DoDocumentAAction

(which is apparently optional?)

@kleisauke kleisauke mentioned this pull request Apr 21, 2023
Closed
@jcupitt
Copy link
Member

jcupitt commented Apr 21, 2023

Oh, very nice!

I tested with the sample PDF from the linked issue and I confirm that this fixes the issue.

I also tested under valgrind and saw no leaks.

LGTM!

@kleisauke kleisauke changed the title pdfiumload: support forms pdfiumload: add support for forms Apr 22, 2023
@kleisauke kleisauke merged commit 0c81f5a into libvips:master Apr 22, 2023
@kleisauke kleisauke deleted the pdfium-form-fill branch April 22, 2023 09:11
@DarthSim DarthSim mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF load with pdfium does not support PDF forms
2 participants
@kleisauke @jcupitt