heif{load,save}: guard against NULL strings
#3608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would prevent a `NULL` string from being printed with `vsnprintf` in case of a write error. See: libvips#3588.
error->message is initializedNULL strings
|
I simplified/improved this with commit b3bfa34. PTAL. |
lovell
approved these changes
Aug 14, 2023
|
@kleisauke Sorry just saw this. Would it make sense to do the NULL check in the |
|
C doesn't allow that, unfortunately, unless you parse the format string yourself. |
|
Indeed, it would be a bit difficult to do this in But, "better safe than sorry". :) |
|
Ah I see, you're right this would be very clunky to NULL check. Thanks for the fast replies and fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would prevent a
NULLstring from being printed withvsnprintfin case of a write error.See: #3588.
Targets the 8.14 branch.