Fix a crash in jxlsave #3620
Merged
Fix a crash in jxlsave #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of GraphicsMagick can report rgb colourspace for some mono BMPs. In turn, this can trigger a crash in jxlsave. See #3619
|
Some tests fail if you run with graphicsmagick, but I don't see an easy way to fix them, unfortunately. I suppose we'd need some way for pyvips to detect if libvips was running with graphicsmagick. |
lovell
reviewed
Aug 24, 2023
Co-authored-by: Lovell Fuller <[email protected]>
Co-authored-by: Lovell Fuller <[email protected]>
|
🤦 thanks Lovell, copy-paste error :( |
lovell
approved these changes
Aug 24, 2023
I could cherry-pick this to 8.14 and make a new release if needed. However, given that we already warn users in our documentation about the security concerns when processing untrusted images via *magick, it's probably fine to leave this fix only on the master branch (assuming this crash can only occur with GraphicsMagick and v8.15.0 is released in a couple of weeks). |
kleisauke
approved these changes
Aug 24, 2023
jcupitt
added a commit
that referenced
this pull request
Aug 24, 2023
Some versions of GraphicsMagick can report rgb colourspace for some mono BMPs. In turn, this can trigger a crash in jxlsave. See #3619
kleisauke
pushed a commit
to kleisauke/libvips
that referenced
this pull request
Sep 17, 2023
Some versions of GraphicsMagick can report rgb colourspace for some mono BMPs. In turn, this can trigger a crash in jxlsave. See libvips#3619 (cherry picked from commit 0297086)
Merged
kleisauke
pushed a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of GraphicsMagick can report rgb colourspace for some mono BMPs. In turn, this can trigger a crash in jxlsave.
See #3619
@kleisauke this is against master, though since it's a crash (under some circumstances) maybe it should be cherrypicked for 8.14?