Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first go at code for converting image with nclx/CICP signals to scRGB. It's incomplete and was only briefly tested for my use case: HDR AVIF with PQ transfer and Display P3 primaries.
It seems to work reasonably well so far and the output JPG and PNG look much better than using copy.
Specifically the ultrahdr output in the JPG looks pretty good if the gainmap is shown.
pics.zip
In the zip you can find the original AVIF, the non-CICP-aware out_copy.jpg, and the CICP2scRGB outputs (both PNG and JPG, but original PNG was too large).
TODO: