Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix type_map() #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcupitt merged 1 commit into from
Sep 21, 2024
Merged

Fix type_map() #488

jcupitt merged 1 commit into from
Sep 21, 2024

Conversation

@kleisauke
Copy link
Member

@kleisauke kleisauke commented Jul 15, 2024

We cannot declare VipsTypeMap2Fn as opaque as this callback is used by type_map(). Instead, restore the VipsTypeMap2Fn definition and use an opaque pointer for the second argument of vips_type_map().

Details 
$ python3 gen_cpp_binding.py
Traceback (most recent call last):
  File "/home/kleisauke/wasm-vips/build/gen_cpp_binding.py", line 295, in <module>
    generate_enums_flags('enums.cpp')
  File "/home/kleisauke/wasm-vips/build/gen_cpp_binding.py", line 230, in generate_enums_flags
    type_map(type_from_name('GEnum'), add_enum)
  File "/home/kleisauke/.local/lib/python3.12/site-packages/pyvips/base.py", line 105, in type_map
    cb = ffi.callback('VipsTypeMap2Fn', fn)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected a function ctype, got 'VipsTypeMap2Fn'

Regressed since: #464.

@kleisauke
Fix type_map()
d2bdf90 
We cannot declare `VipsTypeMap2Fn` as opaque as this callback is used
by `type_map()`. Instead, restore the `VipsTypeMap2Fn` definition and
use an opaque pointer for the second argument of `vips_type_map()`.
@kleisauke kleisauke mentioned this pull request Aug 26, 2024
Merged
@jcupitt jcupitt merged commit 2c67877 into libvips:master Sep 21, 2024
@kleisauke kleisauke deleted the fix-type-map branch September 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kleisauke @jcupitt