LPD-55579 #74
Closed
LPD-55579 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbrokke
requested changes
Sep 6, 2025
…or SaaS backups, which require additional post-processing
…es file that Liferay will check
…t allow backups to be more easily used locally
…feray Spinner does
…t finding the environment folder
…lper container wouldn't have been created, so make sure it's created
|
Changes merged here: #103. Thank you! @holatuwol at this point I'd say rebase your branch onto the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of commits
Avoid using the "it" variable because it can get confusing with nested scopes
I was running into a hard to troubleshoot issue with Gradle, because Gradle tells you the task that failed but not really why that task failed because it doesn't include the Gradle text, and as part of debugging it, I changed all the
itto actual variable names to make sure that I wasn't running into a weird variable naming issue. That turned out to be unrelated, but I felt that the code was more readable this way, albeit less compact.Separate database backup import from the image to prepare for SaaS backups
Once we bring Spinner into the picture, we'll need to perform some post-processing on the imported database to make the imported database usable in a local environment, so this commit prepares for that. Also includes a portal property (documented in the README) to decrypt any encrypted database backups using 7zip.
Update company web ID lookup to include any portal properties file that Liferay will check
Once we bring Spinner into the picture, there will be more portal properties files, and any of them might have information about which web ID corresponds to the admin/default instance, so this commit prepares for that.
Always a case-insensitive map instead of converting individual lookup keys
I noticed the addition of a
toTableNamefunction, which was already being done automatically for PostgreSQL (which had all lowercase columns returned) by using a case-insensitive comparator on aTreeMap. While fixing that, I also moved all of the results processing to use common logic to hopefully make all of that more maintainable.Add user password reset and other features from spinner that allow backups to be more easily used locally
SaaS database support. After a database is imported, we run various queries to sanitize the data so that there are fewer issues when trying to use the database locally.
Load configurations from liferay-lxc repository, the way Liferay Spinner does
SaaS configuration files support. Adds a portal property (documented in the README) to specify where to copy the configurations from, where applicable.