LPD-64975 Technical Task | [Composer] Add mail server support #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbrokke
requested changes
Sep 15, 2025
There was a problem hiding this comment.
Looks good @annasuszter, just the one comment on the Config class.
| public boolean useDatabaseMySQL = false | ||
| public boolean useDatabasePostgreSQL = false | ||
| public boolean useLiferay = false | ||
| public boolean useMail = false |
There was a problem hiding this comment.
At this point, since we are not actually using this property for anything, we can omit it here.
There was a problem hiding this comment.
Thanks Drew! I updated the PR. The SF failure is probably due to the ongoing releases.liferay.com outage:
* What went wrong:
A problem occurred configuring root project 'liferay-environment-composer'.
> /home/runner/.liferay/workspace/releases.json
a766ff2 to
854fe3e
Compare
drewbrokke
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for LPD-64975
I tested the mail sending with the Groovy script int this article: https://learn.liferay.com/en-us/l/36384420