test(RouterHooks): implement router state testing in init hook #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielvandergeest
requested changes
Aug 26, 2025
There was a problem hiding this comment.
Thanks for this PR! A few comments:
- I'm getting some linting errors, please don't forget to lint:fix before comitting
- I get a warning about modifying the
pageprop, we shouldn't be overwriting props - I'm not sure about the part about queryParams. I don't think query or queryParams even exists on the route state object - why is this part there?
➡️ let's keep the example as simple and clear as possible and test only whether the correct information is available in the router state object in the init hook (in line with the recent change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added router state testing implementation in component's init hook
Set up state handling for path, params, and query parameters
Configured URL hash-based query parameter parsing
Added state information display via JSON.stringify
Testing covers: