lnrpc+channeldb: add reversed flag to ForwardingHistory#10603
lnrpc+channeldb: add reversed flag to ForwardingHistory#10603Janmesh23 wants to merge 1 commit intolightningnetwork:masterfrom
Conversation
Summary of ChangesHello @Janmesh23, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the forwarding history functionality by introducing the ability to query events in reverse chronological order. This improvement provides greater flexibility for users who need to view the most recent forwarding events first, particularly useful for pagination and analysis of recent activity. The changes span the RPC layer down to the database, ensuring consistent behavior and robust testing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a reversed flag to the ForwardingHistory RPC, enabling users to fetch forwarding history in reverse chronological order. The implementation at the database level in channeldb/forwarding_log.go correctly handles both forward and reverse iteration, and a new unit test in channeldb/forwarding_log_test.go provides good coverage for this new functionality. The changes are well-contained and address the feature request effectively. I've included a couple of suggestions to improve code clarity and maintainability in channeldb/forwarding_log.go by addressing some code duplication.
| // If our current return payload exceeds the max number | ||
| // of events, then we'll exit now. |
There was a problem hiding this comment.
This comment block is a duplicate of the one on lines 370-371. It can be removed to improve readability.
| if q.Reversed { | ||
| timestamp, eventBytes = logCursor.Prev() | ||
| } else { | ||
| timestamp, eventBytes = logCursor.Next() | ||
| } |
There was a problem hiding this comment.
This block of code for advancing the cursor is repeated in three places within this loop (here, at lines 442-446, and 457-461). To improve maintainability and reduce redundancy, consider refactoring this logic into a helper closure.
For example:
advance := func() {
if q.Reversed {
timestamp, eventBytes = logCursor.Prev()
} else {
timestamp, eventBytes = logCursor.Next()
}
}You could then replace the repeated blocks with a call to advance().
|
@Janmesh23, remember to re-request review from reviewers when ready |
|
hi @ziggie1984 @Roasbeef ! |
Summary of PR :
Added reversed flag to
ForwardingHistory RPC.Implemented reverse iteration in the database level (
channeldb).Added a comprehensive unit test verifying the new logic and pagination.
Manually updated the generated proto code to ensure the build stays green in this environment.
fixes #10555