Thanks to visit codestin.com
Credit goes to github.com

Skip to content

LCORE-1449: Use proper type specification#1307

Merged
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:use-proper-type-specification
Mar 11, 2026
Merged

LCORE-1449: Use proper type specification#1307
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:use-proper-type-specification

Conversation

@tisnik

@tisnik tisnik commented Mar 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

LCORE-1449: Use proper type specification

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1449

Summary by CodeRabbit

  • Refactor

    • Modernized type declarations using updated Python syntax.

  • Chores

    • Enhanced linting configuration.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8094c39c-1e9e-4e2a-a46b-1ee51ba06ce9

📥 Commits

Reviewing files that changed from the base of the PR and between de8a85a and b86cf64.

📒 Files selected for processing (2)
  • pyproject.toml
  • src/utils/types.py

Walkthrough

The pull request modernizes type alias declarations in the codebase to use PEP 695's new type syntax instead of the older TypeAlias annotation approach, and updates Ruff lint configuration to include the UP010 rule for enforcing this modern syntax.

Changes

Cohort / File(s) Summary
Configuration
pyproject.toml		 Added UP010 to Ruff lint extend-select rules to enforce modern type alias syntax.
Type Alias Syntax
src/utils/types.py		 Converted three type aliases (IncludeParameter, ResponseItem, ResponseInput) from TypeAlias annotation to PEP 695 type syntax; removed unused TypeAlias import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main refactoring work across the PR: updating type alias syntax to use the modern type statement instead of TypeAlias, and enabling the UP010 lint rule to enforce this style.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 1efbba4 into lightspeed-core:main Mar 11, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tisnik