Thanks to visit codestin.com
Credit goes to github.com

Skip to content

LCORE-1536: Retry option for fetching LS providers#1371

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:include_ls_providers_in_lcs_image
Mar 23, 2026
Merged

LCORE-1536: Retry option for fetching LS providers#1371
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:include_ls_providers_in_lcs_image

Conversation

@asimurka

@asimurka asimurka commented Mar 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Fetching LS providers using curl has been unstable probably due to running multiple CI jobs in parallel. This PR adds retry options for fetching LS providers resulting in 3 attempts in total separated by 5s delay.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: N/A

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Improved reliability of the artifact download process by adding retry logic to handle transient network failures during deployment.

@coderabbitai

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49e0301d-e6ed-4adb-b196-6dbdb14a349b

📥 Commits

Reviewing files that changed from the base of the PR and between 3049234 and 058a01c.

📒 Files selected for processing (1)
  • Containerfile

Walkthrough

A single line in the Containerfile was updated to add retry parameters (--retry 2 and --retry-delay 5) to the curl command used for downloading lightspeed-providers.zip when the hermetic artifact is unavailable.

Changes

Cohort / File(s) Summary
Containerfile Download Command
Containerfile		 Added --retry 2 and --retry-delay 5 parameters to curl command for resilience during lightspeed-providers.zip download on fallback path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references the main change: adding retry options to the fetch of Lightspeed providers, which aligns with the changeset that adds --retry 2 and --retry-delay 5 to the curl command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asimurka asimurka changed the title LCORE-1536: Retry option for fetchong LS providers LCORE-1536: Retry option for fetching LS providers Mar 23, 2026
@asimurka asimurka force-pushed the include_ls_providers_in_lcs_image branch from 4c3119b to 058a01c Compare March 23, 2026 07:37
@asimurka asimurka requested a review from tisnik March 23, 2026 07:38
tisnik
tisnik approved these changes Mar 23, 2026
View reviewed changes

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit bb1301f into lightspeed-core:main Mar 23, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisnik tisnik tisnik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asimurka @tisnik