Thanks to visit codestin.com
Credit goes to github.com

Skip to content

LCORE-1556: Fixed docstrings#1380

Merged
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:lcore-1556-fixed-docstrings
Mar 23, 2026
Merged

LCORE-1556: Fixed docstrings#1380
tisnik merged 2 commits into
lightspeed-core:mainfrom
tisnik:lcore-1556-fixed-docstrings

Conversation

@tisnik

@tisnik tisnik commented Mar 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

LCORE-1556: Fixed docstrings

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1556

Summary by CodeRabbit

  • Style

    • Applied consistent code formatting by removing excess whitespace throughout test files.

  • Chores

    • Updated linting configuration to enforce additional code quality standards.

@coderabbitai

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 856c56e9-2575-4a92-a3cd-a66988a569ea

📥 Commits

Reviewing files that changed from the base of the PR and between b043837 and 3225959.

📒 Files selected for processing (16)
  • pyproject.toml
  • tests/integration/endpoints/test_config_integration.py
  • tests/integration/endpoints/test_health_integration.py
  • tests/unit/app/endpoints/test_conversations_v2.py
  • tests/unit/app/endpoints/test_feedback.py
  • tests/unit/app/endpoints/test_tools.py
  • tests/unit/authentication/test_k8s.py
  • tests/unit/authorization/test_resolvers.py
  • tests/unit/metrics/test_utis.py
  • tests/unit/models/config/test_authentication_configuration.py
  • tests/unit/models/config/test_byok_rag.py
  • tests/unit/models/config/test_model_context_protocol_server.py
  • tests/unit/models/requests/test_query_request.py
  • tests/unit/utils/test_endpoints.py
  • tests/unit/utils/test_llama_stack_version.py
  • tests/unit/utils/test_transcripts.py
💤 Files with no reviewable changes (15)
  • tests/integration/endpoints/test_health_integration.py
  • tests/unit/models/config/test_model_context_protocol_server.py
  • tests/unit/app/endpoints/test_tools.py
  • tests/unit/models/requests/test_query_request.py
  • tests/unit/app/endpoints/test_conversations_v2.py
  • tests/unit/authorization/test_resolvers.py
  • tests/unit/authentication/test_k8s.py
  • tests/unit/utils/test_transcripts.py
  • tests/unit/utils/test_llama_stack_version.py
  • tests/unit/models/config/test_authentication_configuration.py
  • tests/unit/app/endpoints/test_feedback.py
  • tests/unit/metrics/test_utis.py
  • tests/unit/utils/test_endpoints.py
  • tests/integration/endpoints/test_config_integration.py
  • tests/unit/models/config/test_byok_rag.py

Walkthrough

This PR updates Ruff linting configuration to enforce the D202 rule (one blank line required between docstrings and code) and applies the corresponding formatting fixes across multiple test files by removing extraneous blank lines.

Changes

Cohort / File(s) Summary
Linting Configuration
pyproject.toml		 Added D202 rule to Ruff lint configuration in [tool.ruff.lint].extend-select.
Test Files — Whitespace Cleanup
tests/integration/endpoints/test_*.py, tests/unit/app/endpoints/test_*.py		 Removed blank lines immediately after docstrings in test functions across integration and unit tests for endpoints and related modules.
Test Files — Authentication & Authorization
tests/unit/authentication/test_k8s.py, tests/unit/authorization/test_resolvers.py		 Removed blank lines after docstrings in test functions following the D202 formatting rule.
Test Files — Models & Configuration
tests/unit/models/config/test_authentication_configuration.py, tests/unit/models/config/test_byok_rag.py, tests/unit/models/config/test_model_context_protocol_server.py, tests/unit/models/requests/test_query_request.py		 Removed blank lines after docstrings in model configuration and request validation tests to comply with D202 rule.
Test Files — Utilities
tests/unit/metrics/test_utis.py, tests/unit/utils/test_endpoints.py, tests/unit/utils/test_llama_stack_version.py, tests/unit/utils/test_transcripts.py		 Removed blank lines after docstrings in utility test functions to enforce consistent formatting across utility modules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the PR, which is to fix docstrings and enforce linter rules (D202) related to docstring formatting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit d78c57e into lightspeed-core:main Mar 23, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tisnik