Thanks to visit codestin.com
Credit goes to github.com

Skip to content

LCORE-1441: Update Konflux deps#1453

Merged
tisnik merged 4 commits into
lightspeed-core:mainfrom
tisnik:lcore-1441-update-konflux-deps
Apr 5, 2026
Merged

LCORE-1441: Update Konflux deps#1453
tisnik merged 4 commits into
lightspeed-core:mainfrom
tisnik:lcore-1441-update-konflux-deps

Conversation

@tisnik

@tisnik tisnik commented Apr 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

LCORE-1441: Update Konflux deps

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1441

Summary by CodeRabbit

  • New Features

    • Added the datasets dependency to the project configuration.

  • Chores

    • Updated many pinned dependencies and hashes across lockfiles (multiple version bumps and provenance updates).
    • Adjusted wheel/hash sets by adding and removing several packages and updating hashes.
    • Shortened the pip prefetch/build package lists used for preparing wheels.
    • Commented out an enforced override for a dataset package.

@coderabbitai

coderabbitai Bot commented Apr 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3e45cc3e-68d9-4dfd-8cfc-33a7d58ad988

📥 Commits

Reviewing files that changed from the base of the PR and between 1d2707e and 64fb8e5.

📒 Files selected for processing (1)
  • pyproject.toml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
  • GitHub Check: E2E: server mode / ci
  • GitHub Check: E2E: library mode / ci
  • GitHub Check: build-pr
🔇 Additional comments (2)
pyproject.toml (2)

232-232: Whitespace-only change is fine.

No action needed for the extra blank line at Line 232.

75-75: ⚠️ Potential issue | 🟡 Minor

Reconcile datasets version constraints in pyproject.toml.

Line 75 specifies datasets>=4.7.0 in main dependencies, while line 168 specifies datasets>=3.6.0 in the optional llslibdev dependency group. These constraints should be aligned to the same minimum version to avoid ambiguity. If both groups are used together, the lower bound (3.6.0) is applied, which may not satisfy the intent of line 75's higher constraint.

Update line 168 to datasets>=4.7.0 to match the primary dependency requirement.

⛔ Skipped due to learnings 
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-05T12:19:35.985Z
Learning: Always verify current library versions in `pyproject.toml` rather than assuming versions

Walkthrough

Updated Tekton pipeline prefetch package lists, bumped/adjusted build pins in requirements-build.txt, and synchronized dependency lock/hash and override files with multiple version, hash, and provenance changes.

Changes

Cohort / File(s) Summary
Tekton pipelines
.tekton/lightspeed-stack-pull-request.yaml, .tekton/lightspeed-stack-push.yaml		 Modified the prefetch-input binary.packages comma-separated lists: removed multiple packages (e.g., click, google-resumable-media, google-cloud-core, grpc-google-iam-v1, pygments, tzdata, mcp, etc.) and updated the pip prefetch strings.
Build dependency pins
requirements-build.txt		 Bumped dunamai 1.26.0→1.26.1 and pdm-backend 2.4.7→2.4.8; removed setuptools==82.0.0 from the unsafe section and adjusted provenance/comments for several entries.
Source dependency hashes
requirements.hashes.source.txt		 Updated many pinned package versions and SHA256 hashes (multiple bumps and additions such as autoevals, chardet, fastapi, google-cloud-*, pyopenssl, trl, uvicorn, added tzdata, etc.) and added/updated entries like click, datasets, grpc-google-iam-v1, google-cloud-core, google-resumable-media, mcp, pygments.
Wheel dependency hashes
requirements.hashes.wheel.txt		 Removed several wheel hash entries (e.g., click, datasets, google-cloud-core, google-resumable-media, grpc-google-iam-v1, mcp, pygments, tzdata) and bumped hashes/versions for dill and fsspec.
Overrides
requirements.overrides.txt		 Commented out/removed active override pin for datasets==4.5.0 (no longer enforced).
Project metadata
pyproject.toml		 Added datasets>=4.7.0 to project.dependencies and a minor whitespace change in [tool.ruff.lint].

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating Konflux dependencies across multiple configuration files and dependency lockfiles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit ce3a03f into lightspeed-core:main Apr 5, 2026
25 of 26 checks passed
jrobertboos pushed a commit to jrobertboos/lightspeed-stack that referenced this pull request Apr 14, 2026
@tisnik @jrobertboos
LCORE-1441: Update Konflux deps (lightspeed-core#1453)
c6f2052 
* LCORE-1441: Update Konflux deps

* Datasets update

* Updated lockfile

* Updated project file
Anxhela21 pushed a commit to Anxhela21/lightspeed-stack that referenced this pull request Apr 27, 2026
@tisnik @Anxhela21
LCORE-1441: Update Konflux deps (lightspeed-core#1453)
4c7e232 
* LCORE-1441: Update Konflux deps

* Datasets update

* Updated lockfile

* Updated project file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tisnik