Merged
Conversation
…cs (small conflicts)
…e/lightlab into cleaning-up-docs
bugfix labstate.json for servers not loading (affects cassander) See merge request StealthCode/lightlab!56
…htlab into development
Driver_attenuator_HP8157A_VA See merge request StealthCode/lightlab!58
Travis integration with pypi
Member
Author
|
@atait do you think you can give a quick look sometime this week? |
atait
approved these changes
Jun 19, 2018
Collaborator
atait
left a comment
There was a problem hiding this comment.
Looks like more documentation, fewer bugs, a couple drivers, etc. Looks good for me. CI will be really nice
Member
Author
|
CI works.
Didn’t work in this particular case because you can only upload a version once to PyPI.
But from 1.0.4 onwards it will be seamless. Every tag will be deployed.
On 19 Jun 2018, at 17:30, atait <[email protected]<mailto:[email protected]>> wrote:
@atait approved this pull request.
Looks like more documentation, fewer bugs, a couple drivers, etc. Looks good for me. CI will be really nice
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABCcky-hFsRkxilxNErtWmf45Byn6HvGks5t-W2FgaJpZM4UovBz>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Please create a tag v1.0.3 after this pull request is completed. A wheel is going to be packaged and upload to PyPI.