Allow Symfony 8#1642
Merged
Merged
Conversation
ecc772e to
f572bf7
Compare
dmaicher
commented
Oct 29, 2025
| with: | ||
| dependency-versions: ${{ matrix.dependencies }} | ||
| env: | ||
| SYMFONY_REQUIRE: "${{ matrix.symfony }}" |
Contributor
Author
There was a problem hiding this comment.
using this ENV to force a specific Symfony version is more standard nowadays
dbu
approved these changes
Oct 30, 2025
Member
dbu
left a comment
There was a problem hiding this comment.
awesome! and also great that it just works out of the box.
thanks a lot for the work! i will merge but i guess we wait with tagging until symfony 8.0.0 is tagged, just to be sure not to produce a problematic version.
Member
|
yeah enqueue support for sure will be remove in the next version, symfony messenger is the way to go with a symfony bundle. if we even need an explicit message queue support - providing clear services to warm the cache should be the priority, and then a message queue integration should become so trivial that it could just be a section in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Symfony 8 compatibility.
I added a dev dependencies CI build for now. A bit annoying is the dev dependency on https://github.com/php-enqueue/enqueue-bundle which seems dead 🤔 So I removed that bundle for the Symfony 8 version on CI.