This repository was archived by the owner on May 4, 2026. It is now read-only.
Loss of data for datetime fields if using a getter/setter#44
Merged
dbu merged 3 commits intoMar 4, 2024
Merged
Conversation
…, leading to loss of data
32da8a3 to
2c805f6
Compare
Contributor
Author
|
The second to last commit of that PR also had a bug if i remember correctly, that PhpStan accidentally caught. Would it be weird to make a phpstan analysis of the generated code part of the automated tests? |
dbu
approved these changes
Mar 4, 2024
Member
dbu
left a comment
There was a problem hiding this comment.
thanks for digging into this and providing the fix.
using phpstan on the generated code sounds like an interesting idea indeed. if it does not give us lots of false positive, i am all for it. want to try a pull request?
i will fix the cs issues separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #39 , support for multiple datetime deserialization formats was added, but there is a bug where if the field requires a setter, the temporary variable made to hold the DateTime object has the same name as the temporary that will be passed to the setter.
I've used the same script as in that PR, and fixed the mistake where
start_dateandend_dateof the test data array were written in camelCase instead of snake_case. The issue appears when theCourse::startDateorCourse::endDatefields are set to private instead of public. the{{ date }}variable is the same as the{{ modelPath }}, and is unset by the end of the sectionP.S.: First time I've made a PR with the tests first 🥳 but it's due to my own mistake😞