Refuse to re-propose a pending block signed by a different owner#6371
Merged
Conversation
pull Bot
pushed a commit
to Spencerx/linera-protocol
that referenced
this pull request
May 25, 2026
## Motivation `process_pending_block_without_prepare` calls `self.identity()` _again_, rather than taking the identity from the pending block. This can make the client submit a block signed by the wrong key, which is invalid. ## Proposal Sign with the correct key. ## Test Plan A regression test was added. ## Release Plan - Could be backported, but linera-io#6371 already works around it. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
added a commit
that referenced
this pull request
May 25, 2026
## Motivation Fix race condition between block proposals and changes in the preferred owner ## Proposal * revert #6371 * backport the cleaner solutiom #6378 ## Test Plan CI --------- Co-authored-by: Mathieu Baudet <[email protected]> Co-authored-by: Andreas Fackler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solve a client-side error seen in production, likely happening when we change the preferred owner while a pending proposal exists from the previous owner.
Proposal
InvalidSignerany way.Fortunately, we don't persist pending blocks in storage any more so users could reload the page and continue.
Test Plan
CI