linera-service: remove linera net up --kubernetes (backport of #6325)#6564
Merged
Merged
Conversation
`linera net up --kubernetes` launched a local KinD cluster via Helmfile
to test infra config changes. Since infra now lives in ArgoCD with
automated sync on merge, any change to linera-infra deploys immediately
to the real clusters — testing via a local KinD cluster no longer serves
a purpose.
Remove the `kubernetes` feature and all code exclusively used by that
path:
- Delete
`linera-service/src/cli_wrappers/{local_kubernetes_net,docker,helmfile,kind,kubectl,util}.rs`
- Remove the `kubernetes: true` CLI match arm and related
`NetCommand::Up` fields from `command.rs`
- Remove `handle_net_up_kubernetes` from `net_up_utils.rs`
- Remove the `kubernetes` feature and its optional deps (`k8s-openapi`,
`kube`, `pathdiff`, `fs_extra`) from `linera-service/Cargo.toml` and
workspace `Cargo.toml`
- Delete `.github/workflows/remote-kubernetes-net-test.yml`
- Remove `changed-files-kubernetes` job and `cargo clippy --features
kubernetes` from `.github/workflows/rust.yml`
- Delete `kubernetes/linera-validator/` (the Helm chart + Helmfile
config that backed this feature)
Net: ~-77k lines. `cargo check -p linera-service` and `cargo clippy -p
linera-service` both exit 0.
CI.
- Nothing to do / These changes follow the usual release cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
linera net up --kubernetesand the in-treekubernetes/linera-validatorHelm chart are obsolete: validator deployment is now driven by the ArgoCD setup inlinera-infra. The feature also carried a flaky, disabled CI job (remote-kubernetes-net-test) and a stack ofcli_wrappers(helmfile/kind/kubectl/docker/local_kubernetes_net) that nothing else uses.This backports #6325 (already merged to
main) totestnet_conwayso the two branches do not diverge.Proposal
Remove
linera net up --kubernetesand everything specific to it:kubernetes/linera-validatorHelm chart directory;kubernetescargo feature and itsk8s-openapi/kube/pathdiff/fs_extradeps;cli_wrappers/{helmfile,kind,kubectl,docker,local_kubernetes_net,util}.rs;handle_net_up_kubernetesand the--kubernetesCLI branch;remote-kubernetes-net-testworkflow and thekubernetes-gatedtest_cases inlinera_net_tests.rs.Native (
net up) andremote-netpaths are untouched.Test Plan
CI. Locally on the
testnet_conwaytoolchain:cargo check -p linera-service --all-features --testsandcargo clippy -p linera-service --all-features --testsboth pass,cargo fmt --checkclean.Release Plan
Links
remote-kubernetes-net-testreliability issue — resolved by removing the feature)