Ignore ReaderDiscarded exception on retries #1609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #1594 – Linkerd occasionally throws
ReaderDiscarded
exceptions when discarding a response on retries. Since nothing is actually wrong, we want to silence these exceptions.I've added a
Try
to the call toresponse.discard
inRetryFilter.scala
. TheIOException
"Connection reset by peer" is not silenced, since it appears to be both thrown and caught in code we don't own & it would be difficult to quash this exception only on retries.Tested this against the Kubernetes config described by @esbie in #1594 (comment); the
RetryDiscarded
exception no longer appears in the logs.Closes #1594.