Add request parameters to identified request path in the io.l5d.path identifier
#1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
016a8a3 to
8b5fed5
Compare
…path Signed-off-by: Dennis Adjei-Baah <[email protected]>
108d50c to
f7eee3c
Compare
adleong
reviewed
Dec 7, 2017
| def apply(req: Request): Future[RequestIdentification[Request]] = | ||
| req.path.split("/").drop(1) match { | ||
| case path if path.size >= segments => | ||
| val params = req.getParams() |
There was a problem hiding this comment.
rather than getting and re-encoding the query string, I would just do something like:
val query = {
val u = req.uri
u.indexOf('?') match {
case -1 => ""
case n => u.substring(n)
}
}
Signed-off-by: Dennis Adjei-Baah <[email protected]>
Merged
hawkw
added a commit
that referenced
this pull request
Dec 15, 2017
## 1.3.4 2017-12-15 Linkerd 1.3.4 continues the focus on reliability and stability. It includes a bugfix for HTTP/2 and gRPC routers, several improvements to the Consul namer and dtab store, fixes for 4xx responses in the Kubernetes namer, and more. * Fix an issue where the `io.l5d.path` identifier would consume query parameters from the request URL, preventing them from reaching the downstream service ([#1734](#1734)). * Several minor fixes to documentation and examples. * Consul * Improve handling of invalid namespaces in Namerd's Consul dtab store ([#1739](#1739)). * Add backoffs to Consul dtab store observation retries ([#1742](#1742)). * Fix `io.l5d.consul` namer logging large numbers of spurious error messages during normal operation ([#1738](#1738)). * HTTP/2 and gRPC * Fix buffer data corruption regression introduced in 1.3.3 ([#1751](#1751)). Thanks to [@vadimi](https://github.com/vadimi), who contributed to this fix! * Kubernetes * Improve handling of Kubernetes API watch errors in `io.l5d.k8s` ([#1744](#1744), [#1752](#1752)). * Namerd * Fix `NoHostsAvailable` exception thrown by `io.l5d.mesh` when Namerd has namers configured with transformers ([#1729](#1729)). Signed-off-by: Eliza Weisman <[email protected]>
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this pull request
Dec 20, 2018
… our backlog relevant (linkerd#1734) Signed-off-by: Adam Christian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
io.l5d.pathidentifier this these config valuesand a request url like
GET /mysvc?param=1¶m=2Linkerd would drop the query parameters when sending the request for dtab delegation.This PR makes sure that query parameters are added to the dtab request url if the query parameters are available. This was tested with a local instance of Linkerd talking to a simple service that accepted requests with params.
fixes #1725