Add media query to modify dashboard appearance on large screens #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, this might be more work than it's worth, but is it possible to not scale the elements on the left side of the red line?
|
|
Golden Buoy Award for this branch |
|
@siggy - I've now coerced it into doing that. It kiiiiind of breaks the idea that we were doing responsive columns, a la bootstrap, but it does look less weird. This is what it looks like now, let me know what you think:
|
|
⭐ 👍 i think it looks great! we can always double back at some point to get more responsiveness. |
8e921a9 to
cd8e26d
Compare
|
⭐ 📊 |
| /* globals UpdateableChart */ | ||
| /* exported ClientSuccessRateGraph */ | ||
| var ClientSuccessRateGraph = (function() { | ||
| var columnGridPadding = 27; // grom our css grid setup |
There was a problem hiding this comment.
hehe this is our fav number 🎩 🐰
|
👍 🎩 🐰 |
cd8e26d to
844accc
Compare
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this pull request
Dec 20, 2018
The telemetry service in the controller pod uses a non-fully qualified URL to connect to the prometheus pod in the control plane. This PR changes the URL the telemetry's prometheus URL to be fully qualified to be consistent with other URLs in the control plane. This change was tested in minikube. The logs report no errors and looking at the prometheus dashboard shows that stats are being recorded from all conduit proxies. fixes linkerd#414 Signed-off-by: Dennis Adjei-Baah [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
I used viewport widths rather than pixels, and guestimated on reasonable values for our col-md choices.
Now if you widen the window the dashboard will scale.
Let me know what you think. Latency table does look a little weird.
Here are some screenshots of various widths: