Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow linkerd-examples to accept arguments #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2016
Merged

Allow linkerd-examples to accept arguments #475

merged 1 commit into from
Jun 14, 2016

Conversation

adleong
Copy link
Member

@adleong adleong commented Jun 13, 2016 •
edited
Loading

Problem

The run task on the linkerd example configurations does not accept arguments:

$ ./sbt 'linkerd-examples/transit:run --log.level=DEBUG'
[info] Loading project definition from /Users/alex/workspace/linkerd/project
[info] Set current project to all (in build file:/Users/alex/workspace/linkerd/)
[error] Expected key
[error] Expected '::'
[error] Expected end of input.
[error] linkerd-examples/transit:run --log.level=DEBUG

Solution

Parse arguments using "the exotic, elusive creature known as inputTaskDyn, with which even Stack Overflow cannot help you" (1) and feed them into run.

(1) sbt/sbt#999

@adleong adleong self-assigned this Jun 13, 2016
@olix0r
Copy link
Member

olix0r commented Jun 13, 2016 •
edited by adleong
Loading

⭐ wow. this must have been a fun one!

Approved with PullApprove

@esbie
Copy link
Contributor

esbie commented Jun 13, 2016 •
edited by adleong
Loading

⭐ yay thank you!

Approved with PullApprove

@adleong adleong merged commit 690c230 into master Jun 14, 2016
@adleong adleong deleted the alex/inputtaskdyn branch June 14, 2016 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adleong adleong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adleong @olix0r @esbie