Make the logging page look more like the dashboard page #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
|
|
||
| def apply(req: Request, svc: Service[Request, Response]) = { | ||
| svc(req).map(response => { |
There was a problem hiding this comment.
style nit:
svc(req).map { response =>
...
}
|
⭐ 🎄 |
* Use haxx to put dashboard styles on the Twitter Server logging page
13e7bcf to
eda862e
Compare
| } | ||
|
|
||
| .table-striped>thead>tr { | ||
| border-bottom: 3px solid gray; |
There was a problem hiding this comment.
my preference for these borders is 1px solid dimgray or 1px solid slategray
4 tasks
rmars
added a commit
that referenced
this pull request
Jun 24, 2016
* consolidate versions of the navbar that we use * add router name toggle to linkerd dashboard page * handle router name as params in the dashboard page, like we do in the delegator * delete the css files under /styleguide, as we no longer care to keep the admin dashboard in sync with linkerd.io * #499 the linkerd delegator page now is consistent with the dashboard (and now looks like the namerd one) * #501 Make the logging page look more like the dashboard page
|
(addressing esbie's comments in #505) |
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this pull request
Dec 20, 2018
The existing telemetry pipeline relies on Prometheus scraping the Telemetry service, which will soon be removed. This change configures Prometheus to scrape the conduit proxies directly for telemetry data, and the control plane components for control-plane health information. This affects the output of both conduit install and conduit inject. Fixes linkerd#428, linkerd#501 Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent: rmars/style-followupFollow up to #499 and #497
I've added our own js/css by creating a filter that adds things to the response body. Let me know your opinions on this.
Also colors/styles can be tweaked, opinions welcome.