Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

adleong
Copy link
Member

@adleong adleong commented Aug 10, 2016

No description provided.

@adleong adleong self-assigned this Aug 10, 2016
@adleong
Copy link
Member Author

adleong commented Aug 10, 2016

Approved with PullApprove

@adleong adleong merged commit 2dc28ce into master Aug 10, 2016
@adleong adleong deleted the alex/0.7.3 branch August 10, 2016 21:07
ashald pushed a commit to ashald/linkerd that referenced this pull request Aug 14, 2016
ashald pushed a commit to ashald/linkerd that referenced this pull request Aug 15, 2016
ashald pushed a commit to ashald/linkerd that referenced this pull request Aug 15, 2016
ashald pushed a commit to ashald/linkerd that referenced this pull request Aug 16, 2016
ashald pushed a commit to ashald/linkerd that referenced this pull request Aug 17, 2016
ashald pushed a commit to ashald/linkerd that referenced this pull request Aug 17, 2016
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this pull request Dec 20, 2018
… end (linkerd#589)

This PR adds the `request_duration_ms` metric to the Prometheus metrics exported by the proxy. It also modifies the `request_total` metric so that it is incremented when a request stream finishes, rather than when it opens, for consistency with how the `response_total` metric is generated.

Making this change required modifying `telemetry::sensors::http` to generate a `StreamRequestEnd` event similar to the `StreamResponseEnd` event. This is done similarly to how sensors are added to response bodies, by generalizing the `ResponseBody` type into a `MeasuredBody` type that can wrap a request or response body. Since this changed the type of request bodies, it necessitated changing request types pretty much everywhere else in the proxy codebase in order to fix the resulting type errors, which is why the diff for this PR is so large.

Closes linkerd#570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant