Thanks to visit codestin.com
Credit goes to github.com

Skip to content

domainToPath and domainToPathPfx rewrite namers #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2016
Merged

domainToPath and domainToPathPfx rewrite namers #76

merged 1 commit into from
Feb 8, 2016

Conversation

esbie
Copy link
Contributor

@esbie esbie commented Feb 5, 2016

Fixes #68

There's no external documentation yet for rewriting namers. I'm unsure whether to add docs now since they might be changing (#26)?

Here's usage:

- protocol: http
  baseDtab: |
    /serverset/io/buoyant => /io.l5d.fs;
    /host => /$/io.buoyant.http.domainToPathPfx/serverset;
    /method => /$/io.buoyant.http.anyMethodPfx/host;
    /http/1.1 => /method;

@esbie esbie self-assigned this Feb 5, 2016
@siggy
Copy link
Member

siggy commented Feb 5, 2016

lgtm 👍 ⭐

agree about delaying doc updates if things are in flux.

olix0r
olix0r reviewed Feb 5, 2016
View reviewed changes
router/http/src/main/scala/io/buoyant/http/namer.scala Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copypasta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! thanks

@olix0r
Copy link
Member

olix0r commented Feb 5, 2016

looks like that one comment is wrong but otherwise
image

@rmars
Copy link
Contributor

rmars commented Feb 5, 2016

👍 lgtm

@esbie esbie force-pushed the esbie/domainToPath branch from adfd6a4 to ff1b849 Compare February 8, 2016 17:21
@esbie
Copy link
Contributor Author

esbie commented Feb 8, 2016

⭐ amended with the correct comment

@klingerf
Copy link
Contributor

klingerf commented Feb 8, 2016

Looks good! ⭐ 📡

esbie added a commit that referenced this pull request Feb 8, 2016
@esbie
Merge pull request #76 from BuoyantIO/esbie/domainToPath
70cc382 
domainToPath and domainToPathPfx rewrite namers
@esbie esbie merged commit 70cc382 into master Feb 8, 2016
@esbie esbie deleted the esbie/domainToPath branch February 8, 2016 22:25
@esbie esbie removed the reviewable label Feb 8, 2016
@benley
Copy link
Contributor

benley commented Feb 8, 2016

This looks great :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@esbie esbie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@esbie @siggy @olix0r @rmars @klingerf @benley