Add response_header_modifier outbound http filter #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
hawkw
approved these changes
Jul 1, 2023
olix0r
reviewed
Jul 3, 2023
proto/outbound.proto
Outdated
| @@ -125,6 +125,7 @@ message HttpRoute { | |||
| io.linkerd.proxy.http_route.HttpFailureInjector failure_injector = 1; | |||
| io.linkerd.proxy.http_route.RequestHeaderModifier request_header_modifier = 2; | |||
| io.linkerd.proxy.http_route.RequestRedirect redirect = 3; | |||
| io.linkerd.proxy.http_route.RequestHeaderModifier response_header_modifier = 4; | |||
There was a problem hiding this comment.
Is it really appropriate to use the RequestHeaderModifier type here when handling response headers? Are we absolutely sure these types will remain the same? What is the cost of introducing a distinct type?
Signed-off-by: Alex Leong <[email protected]>
hawkw
approved these changes
Jul 3, 2023
olix0r
approved these changes
Jul 5, 2023
adleong
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Jul 19, 2023
Add support for the response header modifier, which was added to the proxy API in linkerd/linkerd2-proxy-api#251 Signed-off-by: Alex Leong <[email protected]>
hawkw
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jul 26, 2023
Add support for the response header modifier, which was added to the proxy API in linkerd/linkerd2-proxy-api#251 Signed-off-by: Alex Leong <[email protected]> --- * Add suport for response header filter (linkerd/linkerd2-proxy#2439) Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
responseHeaderModifierfilter is an Extended level feature:https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRouteFilter
We add this filter to the outbound proxy-api.