fix: [M3-9705] - IPv6 rDNS does not update immediately in Cloud Manager#12147
Merged
carrillo-erik merged 9 commits intolinode:developfrom May 8, 2025
Merged
fix: [M3-9705] - IPv6 rDNS does not update immediately in Cloud Manager#12147carrillo-erik merged 9 commits intolinode:developfrom
carrillo-erik merged 9 commits intolinode:developfrom
Conversation
hana-akamai
reviewed
May 7, 2025
| const StyledMaterialDesignContent = styled(MaterialDesignContent)( | ||
| ({ theme }: { theme: Theme }) => ({ | ||
| '#notistack-snackbar': { | ||
| alignItems: 'flex-start', |
Contributor
There was a problem hiding this comment.
This positioning was actually intentional #12064
Contributor
Author
There was a problem hiding this comment.
Hmmm, I did review the changes in #11962 and looked at the mocks, but didn't see where this was intentional. I will revert it now. Thanks for pointing this out.
hana-akamai
approved these changes
May 7, 2025
hasyed-akamai
approved these changes
May 8, 2025
Collaborator
Cloud Manager UI test results🎉 586 passing tests on test run #5 ↗︎
|
This was referenced May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR provides the user with visual feedback that updates to a Linode's IPv6 rDNS have been captured, however, those changes may take up to 1 hour to reflect in the Cloud Manager UI. This is accomplished by making the toast notification persist until the user dismisses it.
Changes 🔄
Preview 📷
How to test 🧪
Reproduction steps
We were unable to perform a lookup for 'your-hostname.com' at this time.As a workaround, I edited the Public IPv4 rDNS to trigger the success toast notification since it uses the same component as the IPv6 rDNS toast notification.Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅