Disable bluetooth when suspending without anything connected. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Surface Book 2 it is not possible to archive stable S0ix while bluetooth is enabled but no device is connected. Either S0ix fails completely, or the residency is pretty bad. When bluetooth is disabled, or a device such as the pen is connected, S0ix works fine and residency is great again. By disabling bluetooth when no device is connected, we get proper S0ix in all situations. And since no device is connected, the reset won't really matter. Signed-off-by: Dorian Stoll <[email protected]>
qzed
approved these changes
Sep 24, 2019
Member
|
Thanks! Sorry that I'm currently not more involved with the other issues, I'm trying to get some older stuff done and out of the way. As always, your work is much appreciated! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Surface Book 2, it is not possible to archive stable S0ix while bluetooth is enabled, but no device is connected. Either S0ix fails completely, or the residency is pretty bad. When bluetooth is disabled, or a device (like the pen) is connected to it, S0ix works file and residency is great.
By disabling bluetooth when no device is connected before suspending, we get working S0ix in all situations. And since no device is connected, the reset won't really matter.
Note: There is the case where you disabled bluetooth through the DE before suspending. While the code might look like it would always reenable bluetooth in that case, that doesn't happen. The DE disables bluetooth but doesn't power down the adapter, making
bluetoothctl power ona NOP.