Remove hard systemd dependency from the sleep script #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using nmcli, users who don't use a systemd based distribution (Gentoo etc.), can run the sleep script manually, or hook it up to their service manager manually. This also removes the forced restart if people willingly disabled NetworkManager. Signed-off-by: Dorian Stoll <[email protected]>
qzed
approved these changes
Oct 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @phunyguy on gitter
This removes the hard systemd dependency from the sleep script, by using
nmclidirectly, which is an upstream tool. This makes it possible to use the script on distributions like gentoo or void, by running it manually or hooking it up to the service manager that is used.This also removes the forced restart if people willingly disabled NetworkManager.