Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Excludelist doesn't automatically update during runtime #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Korne127 opened this issue Jul 24, 2024 · 3 comments · May be fixed by #287
Open

Excludelist doesn't automatically update during runtime #286

Korne127 opened this issue Jul 24, 2024 · 3 comments · May be fixed by #287

Comments

@Korne127
Copy link

Korne127 commented Jul 24, 2024 •
edited
Loading

linuxdeploy doesn't automatically try to update the exludelist during runtime. This means that when using linuxdeploy, the latest excludelist is always the excludelist shipped with the used linuxdeploy version.

This is problematic as it requires a new linuxdeploy version to be shipped and downloaded / used by everyone in order for excludelist changes to take effect. This also means that updates have to "trickle down" as you can see in AppImageCommunity/pkg2appimage#555: (For a tauri project to be updated, they need to wait on tauri being updated. For tauri to be updated, they need to wait on linuxdeploy being updated.) And it creates a single point of failure if there is no new linuxdeploy version after an excludelist update.

Therefore, linuxdeploy should also automatically try to update the excludelist at runtime.
@Korne127 Korne127 mentioned this issue Jul 24, 2024
Merged
@TheAssassin
Copy link
Member

Define "on build time".

At any rate, I'll create a new build to update the binaries.

@TheAssassin
Copy link
Member

Should be updated, please try https://github.com/linuxdeploy/linuxdeploy/releases.

@Korne127 Korne127 changed the title Excludelist doesn't automatically update during build time Excludelist doesn't automatically update during runtime Jul 25, 2024
@Korne127
Copy link
Author

@TheAssassin Build time was probably not the best term to use as it's very ambiguous. I meant the "build time" / packaging time of the AppImages as it's usually the build time of the projects that use linuxdeploy.
But as it's the runtime of linuxdeploy itself, I changed the original wording.
In any case, I just finished a pull request that implements this. It would be great if you could take a lot at it. :D

@Korne127 Korne127 linked a pull request Jul 25, 2024 that will close this issue
Open
@Korne127 Korne127 mentioned this issue Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add automatic excludelist updating at runtime and ignore-excludelist CLI option Korne127/linuxdeploy
2 participants
@TheAssassin @Korne127