Add automatic excludelist updating at runtime and ignore-excludelist CLI option #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An automatic excludelist updating mechanism has been added at runtime. To do this, each time the linuxdeploy command is invoked, it now tries to download the current version of the excludelist, parses it and saves it as a vector. If any of these steps fail, a warning is emitted. For each library that should be tested against the excludelist, the newly downloaded excludelist is now used if it has been saved correctly, and the pre-packaged excludelist otherwise. This feature has been added as previously, it had required a new linuxdeploy version to be shipped and downloaded / used by everyone in order for excludelist changes to take effect. This also meant that updates had to "trickle down" (e.g. when someone uses a framework like tauri that itself uses linuxdeploy) and it created a single point of failure (a possible missing new linuxdeploy version).
A new CLI option (--ignore-excludelist) has been added to linuxdeploy. When using it, the excludelist of the core libraries is ignored and the core libraries that are depended upon are included in the AppDir. The excludelist updating will only take place if this option is not set (as it's not necessary otherwise). Additionally, the code quality has been improved.
|
I just updated this to also add an |
|
@TheAssassin Do you think this can be merged or do you want som changes? I think that especially the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an automatic excludelist updating mechanism at runtime.
With this pull request, each time the
linuxdeploycommand is invoked, it will try to download the current version of the excludelist, parse it and save it as a vector. If any of these steps fail, a warning is emitted.For each library that should be tested against the excludelist, the newly downloaded excludelist will be used if it has been saved correctly, and the pre-packaged excludelist otherwise.
This feature is added because of the reasons stated in #286: Currently, it requires a new
linuxdeployversion to be shipped and downloaded / used by everyone in order for excludelist changes to take effect. This also means that updates have to "trickle down" (e.g. when someone uses a framework liketaurithat itself useslinuxdeploy) and it creates a single point of failure (a possible missing newlinuxdeployversion).This fixes #286.