AppRun hooks for plugins #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes adding more features easier, as there's a clear defined interface to the class and the mechanism can be split into more methods more easily without bloating the AppDir class further.
That makes maintenance easier.
When your IDE is running as an AppImage, the $APPRUN variable is already set in the built-in terminal. Now of course you could just calculate the path of $APPRUN yourself and force-overwrite it in that script; however that's more effort and more likely to break. Therefore it's easier to just introduce and use a custom variable.
|
Merging as build failure is not the branch's fault. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #81, plugins might have to install some setup code to e.g., make libraries look into alternative locations for plugins or other resources, etc. by e.g., exporting environment variables.
This is implemented with this PR as described in the plugin system spec.
Closes #81.